gattrib

Todo List

Global default_paper_height
Can this be const?

Global default_paper_width
Can this be const?

File i_basic.c
Unused function in here, i_update_status(). File is a candidate for removal?

Global rename_pairs [10][64]
maybe make this dynamic

Global s_object_add_net_attrib_to_object (TOPLEVEL *toplevel, OBJECT *o_current, char *new_attrib_name, char *new_attrib_value)
This needs to be filled in.

Global s_object_add_pin_attrib_to_object (TOPLEVEL *toplevel, OBJECT *o_current, char *new_attrib_name, char *new_attrib_value)
Do I really need separate fcns for comps, nets, and pins???

Global s_object_attrib_add_attrib_in_object (TOPLEVEL *toplevel, char *text_string, int visibility, int show_name_value, OBJECT *object)
Does it need to return OBJECT?

File s_string_list.c
This could be implemented using an underlying GList structure. The count parameter could also be eliminated - either store it in the struct or preferably, calculate it when needed - I don't think the speed penalty of traversing the list is significant at all. GDE

File s_table.c
TABLE should also store its dimensions in its own data structure to save carrying the dimensions around separately.

Global s_table_resize (TABLE **table, int rows, int old_cols, int new_cols)
The row and column information could be stored in the TABLE struct.

Global s_toplevel_get_net_attribs_in_sheet (char *netname)
Function doesn't do anything - candidate for removal?

Global s_toplevel_update_net_attribs_in_toplevel (OBJECT *o_current, STRING_LIST *new_net_attrib_list)
Function doesn't do anything - candidate for removal?

File s_visibility.c
There seems to be a lot of duplicated code in this file - a good candidate for refactoring.

Class st_pin_list
Is this still in use? Consider replacing with a GList-based implementation.

Class st_string_list
Consider replacing with a GList-based implementation

Global x_dialog_fatal_error (gchar *string, gint return_code)
Is the GPOINTER_TO_INT() call needed in exit()?
 All Data Structures Files Functions Variables Typedefs Enumerations Enumerator Defines