Bug List

Global a_pan (GSCHEM_TOPLEVEL *w_current, int x, int y)

FIXME? This call will trigger a motion event (x_event_motion()), even if the user doesn't move the mouse Not ready for prime time, maybe there is another way to trigger the motion event without changing the cursor position (Werner)

Global a_zoom_extents (GSCHEM_TOPLEVEL *w_current, const GList *list, int pan_flags)

FIXME? trigger a x_event_motion() call without moving the cursor this will redraw rubberband lines after zooming removed!, it has side effects in the preview of the part dialog need to find another way to trigger x_event_motion() (Werner)

Global g_funcs_filesel (SCM msg, SCM templ, SCM flags)

FIXME -- figure out the magic SCM_ASSERT for the flags

FIXME -- how to deal with conflicting flags? Should I throw a scheme error? Just deal in the c code?

Global generic_filesel_dialog (const char *msg, const char *templ, gint flags)

FIXME if (folder && path) { dup_string (path, folder); g_free (folder); }

Global get_main_menu (GSCHEM_TOPLEVEL *w_current)

This function may leak memory if there is a non-local exit in Guile code. At some point, unwind handlers need to be added to clean up heap-allocated strings.

Global gettext_fn (const gchar *path, gpointer func_data ATTRIBUTE_UNUSED)

Note that we have to discard the 'const' qualifier here to avoid build warnings when gettext is disabled. This is required due to the prototype of the function pointer argument to gtk_item_factory_set_translate_func()

Global i_callback_hierarchy_down_symbol (gpointer data, guint callback_action, GtkWidget *widget)

may cause problems with non-directory symbols

Global i_callback_page_revert (gpointer data, guint callback_action, GtkWidget *widget)

may have memory leak?

Global o_select_visible_unlocked (GSCHEM_TOPLEVEL *w_current)

We can't call o_select_object() because it behaves differently depending on the state of w_current->SHIFTKEY and w_current->CONTROLKEY, which may well be set if this function is called via a keystroke (e.g. Ctrl-A).

Global print_dialog_class_init (PrintDialogClass *class)

Hardcoded 'magic' numbers in this function

Global SCM_DEFINE (add_attrib_x,"%add-attrib!", 5, 0, 0,(SCM target_s, SCM name_s, SCM value_s, SCM visible_s, SCM show_s),"Add an attribute to an object, or floating")

This function does not verify that name_s is actually a valid attribute name.

Global text_edit_dialog (GSCHEM_TOPLEVEL *w_current, const char *string, int text_size, int text_alignment)

FIXME: Set tab's width in the textview widget.

Global text_input_dialog (GSCHEM_TOPLEVEL *w_current)

FIXME: This doesn't work. Why?

Global x_window_open_page (GSCHEM_TOPLEVEL *w_current, const gchar *filename)

This code should check to make sure any untitled filename does not conflict with a file on disk.